Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch dynamic CNV/ODF versions for must gather #907

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

ebattat
Copy link
Collaborator

@ebattat ebattat commented Sep 30, 2024

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Adding dynamic fetch for CNV/ODF version instead of hard coded.

             ^^^^^^^^^^^^^^^^^^^^^

  File "/usr/local/lib/python3.12/site-packages/benchmark_runner/common/logger/logger_time_stamp.py", line 32, in method_wrapper

    raise err  # MethodError(method.__name__, err)

    ^^^^^^^^^

  File "/usr/local/lib/python3.12/site-packages/benchmark_runner/common/logger/logger_time_stamp.py", line 21, in method_wrapper

    result = method(*args, **kwargs)

             ^^^^^^^^^^^^^^^^^^^^^^^

  File "/usr/local/lib/python3.12/site-packages/benchmark_runner/common/oc/oc.py", line 1418, in generate_cnv_must_gather

    raise ValueError("CNV version must be provided")

ValueError: CNV version must be provided

For security reasons, all pull requests need to be approved first before running any automated CI

@ebattat ebattat added the bug Something isn't working label Sep 30, 2024
@ebattat ebattat self-assigned this Sep 30, 2024
@ebattat ebattat added the ok-to-test PR ok to test label Sep 30, 2024
@ebattat ebattat merged commit 0d81bdb into redhat-performance:main Oct 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ok-to-test PR ok to test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants