Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Google Drive & Disable Prometheus during VM validation #901

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

ebattat
Copy link
Collaborator

@ebattat ebattat commented Sep 26, 2024

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

  1. Disable Prometheus during VM verifications - no need to collects prometheus logs during VM verifications.
    We already collect each VM Prometheus when creating it.
  2. Enable Google drive for storing logs in case of errors

For security reasons, all pull requests need to be approved first before running any automated CI

@ebattat ebattat added the bug Something isn't working label Sep 26, 2024
@ebattat ebattat self-assigned this Sep 26, 2024
@ebattat ebattat changed the title Disable Prometheus while VM verifications Disable Prometheus & Enable Google Drive Sep 26, 2024
@ebattat ebattat changed the title Disable Prometheus & Enable Google Drive Enable Google Drive & Disable Prometheus during VM validation Sep 26, 2024
Copy link
Member

@RobertKrawitz RobertKrawitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem with the code, but what is the purpose of disabling Prometheus here? Please update the PR description with that.

@ebattat
Copy link
Collaborator Author

ebattat commented Sep 26, 2024

@RobertKrawitz, updated the description

@ebattat ebattat merged commit fa2aaab into redhat-performance:main Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants