Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix github secret #900

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

ebattat
Copy link
Collaborator

@ebattat ebattat commented Sep 26, 2024

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

We cannot use a temporary github secret.
For details see
https://docs.github.com/rest/actions/secrets#get-a-repository-public-key

For security reasons, all pull requests need to be approved first before running any automated CI

@ebattat ebattat added the bug Something isn't working label Sep 26, 2024
@ebattat ebattat requested a review from athiruma September 26, 2024 06:38
@ebattat ebattat self-assigned this Sep 26, 2024
@@ -84,7 +84,7 @@ jobs:
QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }}
QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD }}
IBM_API_KEY: ${{ secrets.IBM_API_KEY }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GIT_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@athiruma athiruma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ebattat ebattat merged commit 3d8adce into redhat-performance:main Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants