vdbench vm image warmup #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebattat
force-pushed
the
add_vdbench_vm_warmup
branch
2 times, most recently
from
ac46644
to
ec40b28
Compare
RobertKrawitz
requested changes
Sep 5, 2023
RobertKrawitz
requested changes
Sep 5, 2023
| @@ -361,7 +366,7 @@ jobs: | |||
| # Backup dashboard.json before before adding dashboard version by Python code | |||
| cp -p "$GITHUB_WORKSPACE"/benchmark_runner/grafana/perf/dashboard.json "$GITHUB_WORKSPACE"/benchmark_runner/grafana/perf/dashboard_backup.json | |||
| # Updates new product versions and override Grafana dashboard | |||
| python "$GITHUB_WORKSPACE"/benchmark_runner/grafana/update_grafana_dashboard.py | |||
| cd "$GITHUB_WORKSPACE" && PYTHONPATH=. python benchmark_runner/grafana/update_grafana_dashboard.py | |||
There was a problem hiding this comment.
Isn't this from another PR (mismerge)?
There was a problem hiding this comment.
Yes, I will create a separate PR for it
| @@ -309,7 +309,7 @@ jobs: | |||
| # Backup dashboard.json before before adding dashboard version by Python code | |||
| cp -p "$GITHUB_WORKSPACE"/benchmark_runner/grafana/perf/dashboard.json "$GITHUB_WORKSPACE"/benchmark_runner/grafana/perf/dashboard_backup.json | |||
| # Updates new product versions and override Grafana dashboard | |||
| python "$GITHUB_WORKSPACE"/benchmark_runner/grafana/update_grafana_dashboard.py | |||
| cd "$GITHUB_WORKSPACE" && PYTHONPATH=. python benchmark_runner/grafana/update_grafana_dashboard.py | |||
There was a problem hiding this comment.
Yes, I will create a separate PR for it
ebattat
force-pushed
the
add_vdbench_vm_warmup
branch
from
ec40b28
to
ec1911c
Compare
RobertKrawitz
approved these changes
Sep 5, 2023
ebattat
force-pushed
the
add_vdbench_vm_warmup
branch
from
ec1911c
to
b2d7975
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
vdbench vm workload fails on first run after OCP installation
Looks that the reason is that warmup required for vdbench vm workload for downloading container disk image per node.
Add warmup of vdbench per node.
For security reasons, all pull requests need to be approved first before running any automated CI