Grafonnet: fix python run #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -288,7 +288,7 @@ jobs: | |||
| ELASTICSEARCH_USER: ${{ secrets.PERF_ELASTICSEARCH_USER }} | |||
| ELASTICSEARCH_PASSWORD: ${{ secrets.PERF_ELASTICSEARCH_PASSWORD }} | |||
| run: | | |||
| python "$GITHUB_WORKSPACE"/benchmark_runner/grafana/update_versions_main_libsonnet.py | |||
| PYTHONPATH=. python benchmark_runner/grafana/update_versions_main_libsonnet.py | |||
There was a problem hiding this comment.
Are you guaranteed to be chdir'd to $GITHUB_WORKSPACE at this point? If so, OK, otherwise I would add
cd "$GITHUB_WORKSPACE"
prior to this.
There was a problem hiding this comment.
Updated "$GITHUB_WORKSPACE"
There was a problem hiding this comment.
@RobertKrawitz, pls let me know that its ok
ebattat
force-pushed
the
fix_python_run
branch
from
9b416fe
to
0f3175e
Compare
| @@ -288,7 +288,7 @@ jobs: | |||
| ELASTICSEARCH_USER: ${{ secrets.PERF_ELASTICSEARCH_USER }} | |||
| ELASTICSEARCH_PASSWORD: ${{ secrets.PERF_ELASTICSEARCH_PASSWORD }} | |||
| run: | | |||
| python "$GITHUB_WORKSPACE"/benchmark_runner/grafana/update_versions_main_libsonnet.py | |||
| PYTHONPATH=. python "$GITHUB_WORKSPACE"/benchmark_runner/grafana/update_versions_main_libsonnet.py | |||
There was a problem hiding this comment.
PYTHONPATH=. refers to the current directory. If you're cd'ed into /tmp, say, everything will be referenced relative to /tmp.
A better way to write it would be
cd "$GITHUB_WORKSPACE" && PYTHONPATH=. benchmark_runner/grafana/update_versions_main_libsonnet.py
0f3175e
to
1c09703
Compare
ebattat
force-pushed
the
fix_python_run
branch
from
1c09703
to
e6aa348
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Fix Python run issue by adding
PYTHONPATH=.before running python scriptFor security reasons, all pull requests need to be approved first before running any automated CI