Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build grafonnet job order #642

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fix build grafonnet job order #642

merged 1 commit into from
Aug 28, 2023

Conversation

ebattat
Copy link
Collaborator

@ebattat ebattat commented Aug 28, 2023 •
edited
Loading

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

  1. Fix update_grafana_dashboard grafonnet job order
  2. Fix Grafana integration test: GRAFANA_JSON = > GRAFANA_JSON_PATH

For security reasons, all pull requests need to be approved first before running any automated CI

@ebattat ebattat added the bug Something isn't working label Aug 28, 2023
@ebattat ebattat self-assigned this Aug 28, 2023
@ebattat ebattat added the ok-to-test PR ok to test label Aug 28, 2023
RobertKrawitz
RobertKrawitz approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@RobertKrawitz RobertKrawitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(re-)approved.

@ebattat ebattat merged commit 03817e8 into redhat-performance:main Aug 28, 2023
7 checks passed
@ebattat ebattat changed the title fix build order fix build jobs order Aug 29, 2023
@ebattat ebattat changed the title fix build jobs order Fix build jobs order Aug 29, 2023
@ebattat ebattat changed the title Fix build jobs order Fix build grafonnet job order Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertKrawitz RobertKrawitz RobertKrawitz approved these changes

Assignees

@ebattat ebattat

Labels
bug Something isn't working ok-to-test PR ok to test
Projects
benchmark-runner
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebattat @RobertKrawitz