Update Grafana dashboard by Grafonnet #640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kelchen123, Need to update the description and PR title:
|
ebattat
reviewed
Aug 6, 2023
| @@ -260,10 +260,56 @@ jobs: | |||
| sudo docker push quay.io/${{ secrets.QAUYIO_REPOSITORY }}/${{ secrets.PACKAGE_NAME }}:latest | |||
| echo '⌛ Wait 30 sec till image will be updated in quay.io' | |||
| sleep 30 | |||
|
|
|||
| grafonnet_generator: | |||
There was a problem hiding this comment.
I think we need to change the job name to update_grafana_dashboard instead of grafonnet_generator
| @@ -0,0 +1,7513 @@ | |||
| local g = import 'g.libsonnet'; | |||
There was a problem hiding this comment.
can you please add latest updates in product version ?
|
Adding all those enhancements in PR: #641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the grafonnet generator files, updated Perf_Env_Build_Test_CI.yml file to implement the grafonnet_generator job
Type of change
Note: Fill x in []
Description
Adding ability to update Grafana dashboard by Grafonnet code.
Content:
Dockerfile - Generates Grafana dashboard Json file from Grafonnet code main.libsonnet
Main.libsonnet - Grafana dashboard Grafonnet code
update_grafana_dashboard.py: Python code to override Grafana json dashboard
'update_grafana_dashboard' job to benchmark-runner build job
For more details on grafonnet code
For security reasons, all pull requests need to be approved first before running any automated CI