Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/retrieve: allow skip check and set namespace when retrieving from SB #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Aug 22, 2024

Introduce flags --skip-check and --namespace when retrieving results to allow the command retrieve get results from Standalone executions executed by sonobuoy subsystem. It will take advantage of retry engine implemented in OPCT to prevent issues like that when using native retrieve:

$ opct sonobuoy retrieve
error retrieving results: unexpected EOF

Then now:

$ opct retrieve -n sonobuoy -s
INFO[2024-08-22T17:16:50-03:00] Collecting results...                        
INFO[2024-08-22T17:17:02-03:00] Results saved to /home/mtulio/openshift-labs/opct-base-07/opct_202408221911_b6643aa2-c1dc-4c06-a70e-0185aa79f00a.tar.gz 
INFO[2024-08-22T17:17:02-03:00] Use the results command to check the validation test summary or share the results archive with your Red Hat partner. 

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2024
Copy link

openshift-ci bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mtulio. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtulio mtulio marked this pull request as ready for review August 31, 2024 13:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2024
@openshift-ci openshift-ci bot requested review from faermanj and jcpowermac August 31, 2024 13:23
@mtulio mtulio added kind/bug Categorizes issue or PR as related to a bug. component/CLI labels Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/CLI kind/bug Categorizes issue or PR as related to a bug. target-release/opct-v0.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant