Add the fake login page #66
Conversation
bartoval
commented
Mar 25, 2023
bartoval
commented
- Added interactive login screen
- moved the login logic to LoginScreen.cs
|
would fix #63 |
Scenes/LoginScreen.cs
Outdated
| if (err == Godot.Error.Ok) | ||
| { | ||
| // enable/disable authentication in dev mode | ||
| activateAuthDev = (Boolean)clientConfig.GetValue("auth", "activate_auth_dev"); |
There was a problem hiding this comment.
In the case where there's no config file, we need defaults baked in to the code. When we do a build of the client and distribute it, the config file doesn't get baked in. The config file really only gets used for dev.
There was a problem hiding this comment.
I still have to test these new changes.
Since the configuration values do not change at runtime, it may be worthwhile to create a static class that can be accessed from anywhere in the game, and initialize it in the Main game. This will make it easier to manage and modify the configuration values in the future
There was a problem hiding this comment.
You're welcome to do that. The server just embeds the defaults into the places where the config file is loaded.
| } | ||
|
|
||
| url = OS.GetEnvironment("SERVER_STRING") ?? (String)clientConfig.GetValue("amqp", "server_string", "amqp://127.0.0.1:5672"); |
There was a problem hiding this comment.
I don't consider the case where the required environment variables are not present, in production
