Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Pin 3rd-party actions to SHA1 #1389

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

fbricon
Copy link

@fbricon fbricon commented Feb 17, 2023

Hi!

Following the GH Action Security Hardening guide we should use the commit SHA instead of the branch or tag for any third-party untrusted action.

This PR was submitted by a script.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sadlerap for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1389 (a379ffe) into master (b1e2997) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1389   +/-   ##
=======================================
  Coverage   58.21%   58.21%           
=======================================
  Files          35       35           
  Lines        3011     3011           
=======================================
  Hits         1753     1753           
  Misses       1090     1090           
  Partials      168      168           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e2997...a379ffe. Read the comment docs.

@fbricon
Copy link
Author

fbricon commented Feb 17, 2023

Due to some limitations of the GitHub API, my script can only generate 1 file change per commit. Feel free to squash the PR

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants