test(intelligent-assistant): screen context QE coverage (stacks on #4862) - #4863
Draft
HusneShabbir wants to merge 6 commits into
Draft
HusneShabbir wants to merge 6 commits into
HusneShabbir wants to merge 6 commits into
Conversation
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
…IDP-14319 Fill gating-matrix and kebab RTL gaps, and add mocked Playwright journeys for kebab/chip/pause/fullscreen so QE layers under RHIDP-14768 can gate the Deep Context UX. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
Complete CaptureResult mocks for tsc, and assert paused-send attachments via the same query route pattern used by MCP specs (no try/catch). Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4863 +/- ##
==========================================
+ Coverage 60.14% 60.29% +0.14%
==========================================
Files 2673 2679 +6
Lines 106162 106661 +499
Branches 29807 29955 +148
==========================================
+ Hits 63856 64311 +455
- Misses 41789 41832 +43
- Partials 517 518 +1
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Avoid Escape between kebab verify/enable (it closes the chatbot), re-enable sharing after fullscreen remount for guest e2e, and wait on the Options control in the chat header. Assisted-by: Composer Co-authored-by: Cursor <cursoragent@cursor.com>
… strict mode getByText on the paused label matched both the Label button and inner span; use the same state CSS class pattern as recording/unavailable. Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked QE automation for Deep Context / screen context UX (RHIDP-14319), on top of the product PR.
feat/screen-context-chip). Please merge feat(intelligent-assistant): screen context chip, kebab opt-in, and gated attachments ( #4862 first (or rebase this branch after it lands). Tip commit is test-only.What changed (tip commit)
screen-context-utilsgating matrix (admin/sharing/pause/fullscreen/vision) +buildScreenContextAttachments(DOM + screenshot; degrade when capture fails / DOM throws)LightspeedChatBoxHeaderkebab Enable / Disable screen context when admin flag is one2e-tests/lightspeed.screen-context.test.ts+ helpers: kebab → chip recording; pause/resume; fullscreen unavailable; paused send has no screen-context attachmentsQE tickets
Review tip vs product PR
its-mitesh-kumar:feat/screen-context-chip...HusneShabbir:test/RHIDP-17047-screen-context-coverage
Test plan
workspaces/intelligent-assistant/plugins/intelligent-assistant:yarn test --watchAll=false --testPathPatterns='screen-context-utils|LightspeedChatBoxHeader'workspaces/intelligent-assistant:APP_MODE=legacy npx playwright test e2e-tests/lightspeed.screen-context.test.ts --project=enintelligent-assistant.screen-context.enabled: true, kebab Enable shows chip; pause → send has no image/DOM attachments