Skip to content

fix(image): cache yarn 4.17.1 and 4.12.0 in the sandbox #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
durandom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(image): cache yarn 4.17.1 and 4.12.0 in the sandbox #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/skills/fullsend/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,6 @@ The image must pin the same yarn version the target repos use. Check:
grep packageManager <repo>/package.json
```

If the repo pins `yarn@4.12.0`, the Containerfile must use `corepack prepare yarn@4.12.0 --activate`. A mismatch forces a runtime re-download through the proxy.
If a target repo pins `yarn@4.17.1` (rhdh-plugins, overlays) or `yarn@4.12.0` (rhdh-agentic), the Containerfile must `corepack prepare` those versions. A mismatch forces a runtime re-download through the proxy.

</sandbox_image>
11 changes: 6 additions & 5 deletions images/code/Containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,16 @@ USER root
# YARN_HTTP(S)_PROXY is set at runtime via env files, not baked in.
ENV COREPACK_HOME=/tmp/corepack

# Pin yarn to the version rhdh-plugins uses (packageManager in package.json).
# Using yarn@stable would install the latest (4.16.x), but the repo pins 4.12.0
# and corepack would need to re-download at runtime — wasting time and requiring
# write access to the cache.
# Pin yarn versions the fleet repos use (packageManager in package.json).
# rhdh-plugins + overlays: 4.17.1; rhdh-agentic: 4.12.0. Prepare both so
# corepack does not re-download at runtime through the proxy.
# Using yarn@stable would install whatever is latest and miss the repo pins.
# chmod -R: v1/ subdirectory tree is created as root during prepare, but the
# sandbox user needs write access (corepack updates lastKnownGood.json at runtime).
RUN mkdir -p "$COREPACK_HOME" \
&& corepack enable \
&& corepack prepare yarn@4.12.0 --activate \
&& corepack prepare yarn@4.12.0 \
&& corepack prepare yarn@4.17.1 --activate \
&& yarn --version \
&& chmod -R 777 "$COREPACK_HOME"

Expand Down