Skip to content

chore(intelligent-assistant): 2.1 pre-release changes v1 - #549

Merged
openshift-merge-bot[bot] merged 8 commits into
redhat-developer:mainfrom
michael-valdron:chore-2-1-prerelease-changes-1
Sep 22, 2026
Merged

openshift-merge-bot[bot] merged 8 commits into
redhat-developer:mainfrom
michael-valdron:chore-2-1-prerelease-changes-1

Conversation

@michael-valdron

@michael-valdron michael-valdron commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

Description of the change

Changes contain the following for 2.1 pre-release:

  • Changes image tag reference in compose.yaml and documentation to use 0.7.0rc3 (same as latest_release, should be updated once 0.7.0 is out)
  • Removed default OLLAMA_URL yaml files and Ollama related documentation (not supported in 2.1)
  • Sync latest lightspeed config changes

Which issue(s) does this PR fix or relate to

  • JIRA_issue_link

How to test changes / Special notes to the reviewer

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Run pre-commit run --all-files to run the hooks and then push any resulting changes. The pre-commit Workflow will enforce this and warn you if needed.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@rhdh-qodo-merge

Copy link
Copy Markdown

PR Summary by Qodo

Prepare Intelligent Assistant for the 2.1 pre-release

⚙️ Configuration changes 📝 Documentation 🕐 10-20 Minutes

Grey Divider

AI Description

• Pins Lightspeed Core sidecar defaults and generated references to 0.7.0rc3.
• Removes unsupported Ollama settings from bundled configuration and documentation.
• Synchronizes secret defaults for storage, Vertex AI, OKP, logging, and telemetry.
Diagram

graph TD
  SCHEMA["Values Schema"] --> VALUES["Helm Values"] --> CORE(["Lightspeed Core"])
  README["Chart README"] --> VALUES
  DOCS["Assistant Docs"] --> SECRET["Secret Inputs"] --> CORE
  CONFIG["Provider Config"] --> CORE
Loading
High-Level Assessment

The coordinated approach is appropriate: pinning the release candidate provides reproducible pre-release deployments, while removing Ollama from configuration, secrets, and documentation avoids advertising unsupported functionality. Floating image tags and retaining dormant Ollama settings were considered but would reduce reproducibility or create misleading configuration paths.

Files changed (7) +13 / -29

Documentation (2) +1 / -2
README.mdDocument the 0.7.0rc3 sidecar default +1/-1

Document the 0.7.0rc3 sidecar default

• Updates the generated Backstage chart values table to show Lightspeed Core 0.7.0rc3 as the default sidecar image.

charts/backstage/README.md

intelligent-assistant.mdRemove Ollama credential documentation +0/-1

Remove Ollama credential documentation

• Removes OLLAMA_URL from the supported Intelligent Assistant secret variables because Ollama is unsupported in 2.1.

docs/intelligent-assistant.md

Other (5) +12 / -27
config.yamlRemove the unsupported Ollama provider +0/-4

Remove the unsupported Ollama provider

• Removes the conditional remote Ollama inference provider and its default endpoint from the bundled Lightspeed configuration.

charts/backstage/files/lightspeed/config.yaml

secret.yamlRemove Ollama environment placeholders +0/-2

Remove Ollama environment placeholders

• Drops the ENABLE_OLLAMA and OLLAMA_URL keys from the bundled Lightspeed secret defaults.

charts/backstage/files/lightspeed/secret.yaml

values.schema.jsonUpdate the schema's sidecar image default +1/-1

Update the schema's sidecar image default

• Synchronizes the generated values schema with the Lightspeed Core 0.7.0rc3 image default.

charts/backstage/values.schema.json

values.yamlPin Lightspeed Core to 0.7.0rc3 +1/-1

Pin Lightspeed Core to 0.7.0rc3

• Changes the default Backstage Lightspeed Core sidecar image from 0.5.3 to the 0.7.0rc3 pre-release.

charts/backstage/values.yaml

secret.example.yamlSynchronize Intelligent Assistant secret defaults +10/-19

Synchronize Intelligent Assistant secret defaults

• Adds local persistence paths, Vertex AI credential defaults, OKP credentials, logging, and OpenTelemetry settings. It also removes the introductory usage comments and defaults Vertex AI to the global location.

charts/rhdh/files/intelligent-assistant/secret.example.yaml

@rhdh-qodo-merge

rhdh-qodo-merge Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Vertex users get no credentials ✓ Resolved 🐞 Bug ≡ Correctness
Description
secret.example.yaml sets GOOGLE_APPLICATION_CREDENTIALS to /app-root/gcp-credentials.json and
introduces a host-path variable, but the sidecar only imports this Secret with envFrom and does
not mount that file. When a Vertex user follows the documented template, the configured provider is
directed at a nonexistent credential path unless they separately add an extra volume and sidecar
mount that the example does not supply.
Code

charts/rhdh/files/intelligent-assistant/secret.example.yaml[R11-12]

+GOOGLE_APPLICATION_CREDENTIALS_HOST_PATH: ""
+GOOGLE_APPLICATION_CREDENTIALS: "/app-root/gcp-credentials.json"
Relevance

●●● Strong

Accepted precedent restores missing Lightspeed volumes; this template similarly references a
credential file without mounting it.

PR-#382

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The public documentation directs users to this file as the Secret template, while the pod template
consumes that Secret only as environment variables. Its built-in mounts cover /tmp and the
stack/profile ConfigMaps; credential files require a separately configured extra mount, and the
values documentation explicitly says the referenced file must be mounted.

docs/intelligent-assistant.md[164-178]
charts/rhdh/templates/_backstage-pod-template.tpl[408-412]
charts/rhdh/templates/_backstage-pod-template.tpl[436-449]
charts/rhdh/values.yaml[566-570]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The Intelligent Assistant secret example points Google authentication at `/app-root/gcp-credentials.json`, but the chart does not mount that file and does not consume `GOOGLE_APPLICATION_CREDENTIALS_HOST_PATH`.

## Fix Focus Areas
- charts/rhdh/files/intelligent-assistant/secret.example.yaml[11-12]
- charts/rhdh/values.yaml[566-570]
- docs/intelligent-assistant.md[164-184]

## Recommended Fix
Remove the unsupported host-path variable and either leave `GOOGLE_APPLICATION_CREDENTIALS` unset or document a complete Kubernetes credential Secret, `extraVolumes`, and `intelligentAssistant.core.extraVolumeMounts` example that mounts the JSON file at the configured container path.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
✅ Cross-repo context — repo relationships
  Explored: repo: redhat-developer/rhdh (sha: 81046733)
Review mode: ⚖️ Balanced: This changes Helm chart runtime defaults and provider secret/configuration behavior across multiple files, creating meaningful deployment and compatibility risk despite the small diff.

Grey Divider

Tip of the day
💡 Did you know, you can route each action level your way: inline, summary, both, or drop

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@rhdh-qodo-merge rhdh-qodo-merge Bot added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 22, 2026
@rhdh-qodo-merge

Copy link
Copy Markdown

Important

The /generate_labels command by Qodo is sunsetting on the 1st of October 2026 and will no longer be available. We recommend switching to the latest Qodo review capabilities. Learn more

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Comment thread charts/backstage/values.yaml
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Comment thread charts/rhdh/files/intelligent-assistant/secret.example.yaml
…d secret.example.yaml header

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@sonarqubecloud

Copy link
Copy Markdown

@openshift-ci openshift-ci Bot added the lgtm label Sep 22, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 4519c92 into redhat-developer:main Sep 22, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants