fix: use a task execution facade for Gradle task execution #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Thanks @honourosis I don't know this code base, so let's me some time to test your PR but it looks good. |
|
@angelozerr Are there any updates to this pull request? It looks like macos-runner was broken when the pipeline was running. |
|
LGTM. Thanks @honourosis ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of task execution in
AbstractGradleToolDelegatestrictly relies on the internals of the External System API. This is not necessary, as there is a correspondingly simple way to execute tasks.In addition, some of the used methods will be annotated as
@Internaland will not be available for use by third-party plugins.