Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bind language servers to Project instead of Module #1129

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

angelozerr
Copy link
Contributor

@angelozerr angelozerr commented Aug 28, 2023

fix: Bind language servers to Project instead of Module

Fixes #891

@angelozerr angelozerr changed the title fix: Use project instead of Module fix: Bind language servers to Project instead of Module Aug 29, 2023
@fbricon
Copy link
Contributor

fbricon commented Aug 31, 2023

I tested it on https://github.com/quarkiverse/quarkus-ironjacamar, which is multimodule, didn't see any problem. LGTM

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@angelozerr angelozerr marked this pull request as ready for review September 7, 2023 15:16
@angelozerr
Copy link
Contributor Author

@fbricon is ready now, I have removed all workspace folder support.

@mfortunat this PR should fix your problem with your multi-module #1089 (comment)

@fbricon
Copy link
Contributor

fbricon commented Sep 7, 2023

@angelozerr it looks like properties leak to unrelated projects. e.g. using https://github.com/quarkiverse/quarkus-ironjacamar

The downstream property is resolved on hover in the deployment module, even though it's not on that module's classpath

Screenshot 2023-09-07 at 18 55 50

@angelozerr
Copy link
Contributor Author

@fbricon I think this problem is the same with just one module. We have problem with cache #860

To test this PR,I suggest that you create an application.properties in each module and on each module you define a class with ConfigProperty and you should see the proper properties in completion,validation for each module

@angelozerr
Copy link
Contributor Author

The downstream property is resolved on hover in the deployment module, even though it's not on that module's classpath

I think it is a feature coming from IJ himself, please check that with LSP console traces

@fbricon fbricon merged commit 5d3b511 into redhat-developer:main Sep 7, 2023
11 of 12 checks passed
@fbricon
Copy link
Contributor

fbricon commented Sep 7, 2023

thanks @angelozerr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bind language servers to Project instead of Module
2 participants