-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Bind language servers to Project instead of Module #1129
Conversation
src/main/java/com/redhat/devtools/intellij/lsp4ij/LanguageServerWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/devtools/intellij/lsp4ij/LanguageServerWrapper.java
Outdated
Show resolved
Hide resolved
7180363
to
877cb22
Compare
I tested it on https://github.com/quarkiverse/quarkus-ironjacamar, which is multimodule, didn't see any problem. LGTM |
877cb22
to
75d3513
Compare
Fixes redhat-developer#891 Signed-off-by: azerr <[email protected]>
75d3513
to
bfd1be5
Compare
Kudos, SonarCloud Quality Gate passed! |
@fbricon is ready now, I have removed all workspace folder support. @mfortunat this PR should fix your problem with your multi-module #1089 (comment) |
@angelozerr it looks like properties leak to unrelated projects. e.g. using https://github.com/quarkiverse/quarkus-ironjacamar
The downstream property is resolved on hover in the deployment module, even though it's not on that module's classpath |
@fbricon I think this problem is the same with just one module. We have problem with cache #860 To test this PR,I suggest that you create an application.properties in each module and on each module you define a class with ConfigProperty and you should see the proper properties in completion,validation for each module |
I think it is a feature coming from IJ himself, please check that with LSP console traces |
thanks @angelozerr |
fix: Bind language servers to Project instead of Module
Fixes #891