Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mark @BuildStep-annotated methods as implicitly used #1099

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Aug 10, 2023

fixes #1095

Before:
Screenshot 2023-08-10 at 15 32 45

After:
Screenshot 2023-08-10 at 16 04 10

@gastaldi IJ automatically finds usages in .dot file

@gastaldi
Copy link
Contributor

Nice, but the dot file is generated only if the system property is set during the build

@fbricon
Copy link
Contributor Author

fbricon commented Aug 10, 2023

well yes, but I have no other way at the moment

@angelozerr
Copy link
Contributor

@gastaldi is there any chance that your test this PR?

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@angelozerr
Copy link
Contributor

Nice, but the dot file is generated only if the system property is set during the build

Is it easy to retrive this dot file? What about the format of this dot file? Is it big?

@gastaldi
Copy link
Contributor

Is it easy to retrieve this dot file? What about the format of this dot file? Is it big?

You need to build the application with the -Djboss.builder.graph-output parameter pointing to a file. It can be large, depending on how many extensions your application uses

@fbricon
Copy link
Contributor Author

fbricon commented Aug 10, 2023

Actually you need to build a consumer application. It's like checking if a public method in a framework is used by an application

@gastaldi
Copy link
Contributor

@gastaldi is there any chance that your test this PR?

Just tested with ./gradlew runIde and seems to work as advertised. Good job!

@fbricon fbricon merged commit bd549b4 into redhat-developer:main Aug 10, 2023
11 checks passed
@fbricon
Copy link
Contributor Author

fbricon commented Aug 10, 2023

Thanks for checking @gastaldi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@BuildSteps in an extension processor are considered unused methods
3 participants