Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LSP settings at project scope #1092

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Aug 9, 2023

The Language Servers settings are now scoped to the project (see icon on the right). Meaning the trace levels, debug settings can now be set per project

Screenshot 2023-08-09 at 11 40 10

@fbricon fbricon added enhancement New feature or request lsp4ij LSP client for IJ labels Aug 9, 2023
@fbricon fbricon added this to the 1.25.0 milestone Aug 9, 2023
@fbricon fbricon marked this pull request as ready for review August 9, 2023 16:17
@fbricon
Copy link
Contributor Author

fbricon commented Aug 9, 2023

I need to do the UserDefinedMicroProfileSettings as well

@angelozerr
Copy link
Contributor

It is working like a charm, nice PR!

Please fix Javadoc and I think we can merge it.

The next thing to do is:

  • do the same thing for UserDefinedMicroProfileSettings (as you said)
  • fix the synchronization between the trace settings betwwen the LSP console and the IJ settings page.

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fbricon
Copy link
Contributor Author

fbricon commented Aug 10, 2023

UserDefinedMicroProfileSettings are now project scoped too

trace settings synchro will be addressed in #1062

@angelozerr angelozerr merged commit e56076d into redhat-developer:main Aug 10, 2023
11 checks passed
@angelozerr
Copy link
Contributor

It works great, thanks @fbricon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lsp4ij LSP client for IJ
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants