-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP / PoC: Native multi-cluster openshift-applier run #13
base: main
Are you sure you want to change the base?
Conversation
@oybed Looks good |
@oybed so, with the changes to the role, would that require any changes to existing inventories? |
@etsauer first off, I just updated the title of this PR with This PR is a proposal for how we can handle multi-clusters. The goal would be to not have to change existing inventories, and that should be doable. However, we need to come up with the "improved story" around how we manage OpenShift login sessions, so the solution should be:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
- name: "Capture OpenShift Config based on token" | ||
command: > | ||
oc login --token={{ openshift_token }} {{ openshift_insecure | ternary('--insecure-skip-tls-verify', '') }} {{ openshift_login_url }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause pre-existing applier inventories to fail if not set. I would suggest two things:
- first, make this optional. i.e. skip it if these variables are not set
- set a default value for
openshift_insecure
so that it is not required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etsauer yes, there are multiple things that need to be polished before this can be merged. Main intent for the PR was to have a discussion starting point around the concept (and if it's worth spending time on it)
@oybed understood, and I like the approach. |
Based on the feedback so far, it seems that this approach is worth the effort, so I'll spend some time on finalizing the approach and polish the implementation. |
Another use case I would like to see work: cluster1.yml:
cluster2.yml:
Run:
|
@etsauer are you ok if the prompts are part of the ansible run? Basically something similar to this: |
What does this PR do?
Proposed example of a multi-cluster
openshift-applier
run. Would like to discuss this approach.Note that there's potentially one shortcoming with this approach - i.e.: using
kubeconfig
with pre/post steps. The pre/post step roles will need to be madekubeconfig
aware (unless we find a way to apply it globally on a per-host basis).How should this be tested?
N/A - proposal up for discussion
Is there a relevant Issue open for this?
N/A - proposal up for discussion
Who would you like to review this?
cc: @redhat-cop/openshift-applier