Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for writing supplemental junitxml reports #471

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

komish
Copy link
Contributor

@komish komish commented Aug 27, 2024

fixed #232
deprecates #432

This PR allows a user to write a JUnitXML representation of report core report content at some location on their filesystem by passing in that desired path to a new --write-junitxml-to flag.

This is designed to allow for the conversion of a report on verification to this output format, and write that to the filesystem. I.e. chart-verifier verify can be configured to produce this artifact, but this artifact has no meaning to the chart-verifier report command, and the junitxml does not replace existing YAML/JSON report formats.

Failing to write this report is considered non-fatal at the time of this writing.

@komish komish requested a review from mgoerens August 27, 2024 20:34
@komish
Copy link
Contributor Author

komish commented Aug 27, 2024

@betoredhat PTAL

@komish komish requested a review from jsm84 August 27, 2024 20:34
cmd/verify.go Fixed Show fixed Hide fixed
cmd/verify.go Dismissed Show dismissed Hide dismissed
Copy link

@jsm84 jsm84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@komish komish merged commit 67ede70 into redhat-certification:main Oct 11, 2024
6 checks passed
@komish komish deleted the add-junitxml-support branch October 11, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add support for reports in Junit format
2 participants