Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop extra .tgz from release artifact #464

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

jessesimpson36
Copy link
Contributor

Related to #463

This commit will remove the duplicate .tgz extension from the tarball release artifact.

@mgoerens
Copy link
Contributor

mgoerens commented Aug 7, 2024

Thanks for your contribution !

This LGTM, @komish ?

Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you remove this modification from your commit? whoops - didn't highlight the code. See the next review request for a more accurate representation of what I meant!

@jessesimpson36
Copy link
Contributor Author

I'm sorry, I may have made my modifications too fast. @komish , I removed the whitespace edit I unintentionally added. I'm unclear on if there was something else in your review you would like, as you said

whoops - didn't highlight the code. See the next review request for a more accurate representation of what I meant

I think you only meant to highlight the added newline character.

@komish
Copy link
Contributor

komish commented Aug 7, 2024

@jessesimpson36 You nailed it, thank you!

A quick sidenote, though, I'm fairly certain this doesn't fix the problem you're seeing, but it's still an extra tgz where it doesn't belong, so we'll get this merged shortly.

The issue sits in how openshift-tools-installer is filtering our release assets. I'll look to pursue this either in our pipelines (renaming our assets) or directly with openshift-tools-installer itself. If I pursue the latter, I'll CC you into the conversation, should you want to follow along.

For now, though, I've attached an extra release asset to our 1.13.6 so that your pipeline (and ours) will pass when using openshift-tools-installer.

In my local testing with openshift-tools-installer, it picks up the right release asset now.

Download path of chart-verifier is https://github.com/redhat-certification/chart-verifier/releases
::debug::chart-verifier 1.13.6 files: chart-verifier-1.13.6-linux-amd64.tgz, chart-verifier-1.13.6-sbom.spdx.json, chart-verifier-1.13.6.tgz
Current operating system is linux
::debug::After filterByOS, 1 files remain.
::debug::1 clients remaining; skipping filterByArch.
::debug::1 clients remaining; skipping filterByZipped.
Selecting chart-verifier-1.13.6-linux-amd64.tgz

My apologies! We'll try to get this resolved before our next release.

@jessesimpson36
Copy link
Contributor Author

You're the best. Thank you.

Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@komish komish merged commit caaae61 into redhat-certification:main Aug 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants