Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing chart-verifier from openshift-tools-installer fails due to release asset being malformed #463

Closed
jessesimpson36 opened this issue Aug 6, 2024 · 7 comments

Comments

@jessesimpson36
Copy link
Contributor

Hey all,

My company writes a CI pipeline that makes use of the chart-verifier, but lately our builds have been failing.

2024-08-06-164336_grim

The error reads:

Error: No chart-verifier file was found for amd64 linux .

I thought this was odd, so I went to the openshift-tools-installer code:

https://github.com/redhat-actions/openshift-tools-installer/blob/bee649bbedc67b5bfc2f2de4b19498e11c2e8775/src/installer/install.ts#L76-L95

It looks like it expects the release assets to be of a certain format. When I check the releases in this chart-verifier repo, I see that the asset for the latest release is

2024-08-06-164548_grim

chart-verifier.tgz-1.13.6.tgz

Could someone please rename this to

chart-verifier-1.13.6.tgz ?

@jessesimpson36
Copy link
Contributor Author

Here is the path inside your github actions workflow that duplicates the tgz extension:

TARBALL_NAME="chart-verifier.tgz-${{ steps.get_tag.outputs.release_version }}.tgz"

@jessesimpson36
Copy link
Contributor Author

I opened a PR
#464

that will hopefully address this issue.

@mgoerens
Copy link
Contributor

mgoerens commented Aug 7, 2024

Good catch. I've renamed the tarball in the latest release to chart-verifier-1.13.6.tgz, let me know if that fixes the issue for you.

@jessesimpson36
Copy link
Contributor Author

Thanks for renaming it. For some reason I am still having my issue

Error: No chart-verifier file was found for amd64 linux

But I think I'm on the right track, and am happy about the edit regardless. I will update here if I learn anything more, but I might need to be searching for an issue in the openshift-tools-installer instead.

@komish
Copy link
Contributor

komish commented Aug 7, 2024

Closing the loop on this - I addressed @jessesimpson36's subsequent concern - see #464 (comment)

@jessesimpson36
Copy link
Contributor Author

I confirmed that the hotfix from your comment was enough to make my CI pipeline pass. Thanks again!

@komish
Copy link
Contributor

komish commented Aug 14, 2024

This should be all sorted. Closing this out.

@komish komish closed this as completed Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants