Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline the workflow that generate sbom into the general release tasks #455

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

komish
Copy link
Contributor

@komish komish commented Jul 10, 2024

The github-actions bot is what creates our release, and this bot cannot trigger other workflows. For that reason, our SBOM generation did not trigger because it waits for release events, but it's not being sent because of the previous.

This PR inlines the SBOM generation and attaches it during the release creation.

If SBOM generation fails, we continue as we still want the release to complete.

@komish komish requested a review from jsm84 July 10, 2024 18:20
Copy link

@jsm84 jsm84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@komish komish merged commit a0b0d3e into redhat-certification:main Jul 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants