Use external library to get the OCP versions range #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The translation of range of Kubernetes version to range of OCP versions was previsouly inconsistent accross chart-verifier and the certification pipeline. The code that performs this translation has now been externalized to the github.com/opdev/get-ocp-range repository. See openshift-helm-charts/charts#1032
mgoerens
force-pushed
the
get-ocp-range
branch
from
0cf8d33
to
d9d74a8
Compare
komish
reviewed
Oct 5, 2023
| @@ -549,51 +549,6 @@ func TestRequiredAnnotationsPresent(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestSemVers(t *testing.T) { | |||
There was a problem hiding this comment.
Any particular reason this test needs to change? Has this test been moved to the replacing library?
There was a problem hiding this comment.
These are the unit tests for the getOCPRange function, which is removed from this repo with this commit.
The Go library implements unit tests too, see https://github.com/opdev/getocprange/blob/main/get-ocp-range_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The translation of range of Kubernetes version to range of OCP versions was previsouly inconsistent accross chart-verifier and the certification pipeline. The code that performs this translation has now been externalized to the github.com/opdev/get-ocp-range repository.
See openshift-helm-charts/charts#1032