Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8 step in the build pipeline #401

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

mgoerens
Copy link
Contributor

@mgoerens mgoerens commented Aug 3, 2023

No description provided.

@mgoerens
Copy link
Contributor Author

mgoerens commented Aug 3, 2023

Note that this should be merge after #399

@komish
Copy link
Contributor

komish commented Aug 4, 2023

Does this step fail when the code doesn't match style guidelines? Just want to confirm as applying them here won't do anything, and we want the step to fail so the contributor can make their fixes and repush.

@mgoerens
Copy link
Contributor Author

mgoerens commented Aug 4, 2023

Yes, the step fails if flake8 complains. See for instance: https://github.com/mgoerens/my-chart-verifier/actions/runs/5750215106/job/15586524282

Actually, flake8 only ever emits errors, it doesn't edit the code. I use black for that.

@komish
Copy link
Contributor

komish commented Aug 4, 2023

@mgoerens okay perfect.

One more thing, can we either

  1. Use a GitHub action for Flake8 (e.g. https://github.com/marketplace/actions/flake8-action, but any one you like will be fine)
  2. Install Flake8 into its own venv?

Just looking to separate it a bit to avoid any kind of dependency conflict in ve1.

@mgoerens
Copy link
Contributor Author

mgoerens commented Aug 7, 2023

I now installed flake8 in a dedicated venv.

Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@komish komish merged commit 2b1c528 into redhat-certification:main Aug 8, 2023
5 checks passed
@mgoerens mgoerens deleted the pipeline_flake8 branch August 9, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants