Remove testing using docker #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoerens
force-pushed
the
remove_docker_tests
branch
from
240852a
to
f1ca032
Compare
|
@mgoerens this needs a rebase. The actions/cache@v4 tag didn't exist, so we replaced it with the v3 tag which does and merged that to resolve the setup issue. |
mgoerens
force-pushed
the
remove_docker_tests
branch
from
f1ca032
to
727806a
Compare
|
@komish FYI the pipeline fails as the workflows from the |
|
@mgoerens understood. Makes sense. We can test the behavior here in a fork without issue. |
The container image test is already covered by the podman tests. - Remove testing the container image using docker. - Update the documentation accordingly - Remove the "build-and-test" python script, previously used to build the docker image. - Remove the now unused "report_info" python script. - In places where the podman image is built, use the "build-image" make target. close redhat-certification#378 Signed-off-by: mgoerens <[email protected]>
mgoerens
force-pushed
the
remove_docker_tests
branch
from
727806a
to
ea8d2b4
Compare
|
Tested in mgoerens/my-chart-verifier:
|
komish
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Successful run replicated in my repo as well.
https://github.com/komish/chart-verifier/actions/runs/5742028147
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The container image test is already covered by the podman tests.
close #378