Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action identifiers #368

Merged
merged 1 commit into from
Jul 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
branches: [ main ]

jobs:
build:
build-test-release:
name: Build artifacts
runs-on: ubuntu-latest

Expand Down
19 changes: 16 additions & 3 deletions .github/workflows/dev_release.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
name: Create dev release
name: Create Dev Release
# Delete the previous development release and recreate it
# with code based off of the main branch.
#
# This is done so that the openshift-tools-installer has a valid
# semantic version release to install.
# https://github.com/redhat-actions/openshift-tools-installer

on:
push:
branches:
- main

jobs:
build:
release:
name: Create Dev Release
runs-on: ubuntu-latest
env:
Expand Down Expand Up @@ -53,10 +59,17 @@ jobs:
tag_name: ${{ env.DEV_RELEASE }} # tag name to delete
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

# The next step seems to periodically create a draft release.
# We think this is because of a race condition.
# Force a wait after the previous release was deleted.
- name: Sleep and to buffer release recreation
id: sleep-after-delete-previous
run: sleep 8

- name: Create the release
id: create_release
if: ${{ steps.delete-previous.outcome == 'success' }}
if: ${{ steps.delete-previous.outcome == 'success' && steps.sleep-after-delete-previous == 'success' }}
uses: softprops/action-gh-release@v1
with:
tag_name: ${{ env.DEV_RELEASE }}
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/vulnerability.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
name: CI
name: Run Security Scan

# Triggers the workflow on push or pull request events but only for the main branch
on:
push:
branches: [main]
pull_request:
branches: [main]

jobs:
build-and-validate:
scan:
runs-on: ubuntu-latest

steps:
Expand Down