change expected tag after latest tag was unpublished #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komish
force-pushed
the
image-test-unpublished-tag
branch
2 times, most recently
from
47b795f
to
4d0282d
Compare
|
This required changing a bunch of the fixtures that also had references to the same image with the tag latest. For this reason, you'll see other files modified in this PR, but they aren't exactly easy to evaluate. I've just changed their image references to point to the 1-151 tag for postgresql-10-rhel7. |
jsm84
approved these changes
Jun 30, 2023
Signed-off-by: Jose R. Gonzalez <[email protected]>
komish
force-pushed
the
image-test-unpublished-tag
branch
from
4d0282d
to
bcc12c2
Compare
Signed-off-by: Jose R. Gonzalez <[email protected]>
With the latest tag being removed, we needed to recreate all of the test fixtures to point to an image that actually exists. This also included regenerating report info, a fresh CI GPG key, resigning charts, etc. Signed-off-by: Jose R. Gonzalez <[email protected]>
komish
force-pushed
the
image-test-unpublished-tag
branch
from
5165419
to
d9ca131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out the postgres-10-rhel7 image's[1] latest tag is no longer returned from the Catalog API. I'm not sure if it got unpublished, or what happened, but our test is expecting that image to be there.
This PR changes the target image to another tag that's currently available (and has been for the last 11 months)
[1]https://catalog.redhat.com/software/containers/rhscl/postgresql-10-rhel7/5aa63541ac3db95f196086f1