Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] openshift-tools-installer fails to find chart-verifier releases #108

Closed
komish opened this issue Aug 7, 2024 · 1 comment · Fixed by #109
Closed

[BUG] openshift-tools-installer fails to find chart-verifier releases #108

komish opened this issue Aug 7, 2024 · 1 comment · Fixed by #109
Labels
bug Something isn't working

Comments

@komish
Copy link
Contributor

komish commented Aug 7, 2024

Version

All versions

Describe the bug

openshift-tools-installer fails to find chart-verifier 1.13.6 release binary tarballs in the list of release assets.

Steps to reproduce, workflow links, screenshots

Context

I maintain https://github.com/redhat-certification/chart-verifier.

The problem here is the filtering that's applied within openshift-tools-installer. Chart Verifier undergoes the default release asset filtering (filterByOs, filterByArch, filterByZipped).

In the past, we only had a single release asset that was published. When openshift-tools-installer encounters only a single release asset, it skips remaining filtering (i.e. all filters). Now that we have 2 assets, the first filter (filterByOs) is filtering out everything, and returning 0 assets.

Chart Verifier either needs to rename their release asset, or needs custom filters here. I'm leaning the filtering route for now because there may be other locations that use our release asset names as they exist.

I've got some filters that work. I'll submit them as a PR here shortly.

@komish komish added the bug Something isn't working label Aug 7, 2024
@komish
Copy link
Contributor Author

komish commented Aug 7, 2024

cc @jessesimpson36 - thanks for reporting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant