Update gitignore file to skip OS files

Signed-off-by: Edmund Ochieng <[email protected]>

.gitignore

@@ -3,3 +3,33 @@
 **/reports/
 __pycache__
 .vscode/
+.DS_Store
+
+# Binaries for programs and plugins
+*.exe
+*.exe~
+*.dll
+*.so
+*.dylib
+bin
+testbin/*
+Dockerfile.cross
+
+# Test binary, build with `go test -c`
+*.test
+
+# Output of the go coverage tool, specifically when used with LiteIDE
+*.out
+
+# Kubernetes Generated files - skip generated files, except for vendored files
+
+!vendor/**/zz_generated.*
+
+# editor and IDE paraphernalia
+.idea
+*.swp
+*.swo
+*~
+
+# omit coverage files
+coverage.out

Makefile

@@ -51,7 +51,7 @@ bin_win:
 
 .PHONY: test
 test:
-	go test -v ./...
+	go test -v -coverprofile=coverage.out ./...
 
 # Build the container image. Usage: make build-image IMAGE_TAG=my_tag
 # If IMAGE_TAG is not provided, use the COMMIT_ID

internal/chartverifier/checks/checks.go

@@ -341,7 +341,9 @@ func SignatureIsValid(opts *CheckOptions) (Result, error) {
 		resp, err := http.Get(provFile)
 		if err != nil {
 			return NewResult(false, fmt.Sprintf("%s : get error was %v", SignatureFailure, err)), nil
-		} else if resp.StatusCode == 404 {
+		}
+
+		if resp.StatusCode == 404 {
 			return NewSkippedResult(fmt.Sprintf("%s : %s", ChartNotSigned, SignatureIsNotPresentSuccess)), nil
 		} else if resp.StatusCode != 200 {
 			return NewResult(false, fmt.Sprintf("%s. get prov file response code was %d", SignatureFailure, resp.StatusCode)), nil
@@ -467,12 +469,8 @@ func getOCPRange(kubeVersionRange string) (string, error) {
 }
 
 func downloadFile(fileURL *url.URL, directory string) (string, error) {
-	urlPath := fileURL.Path
-	segments := strings.Split(urlPath, "/")
-	fileName := segments[len(segments)-1]
-
 	// Create blank file
-	filePath := path.Join(directory, fileName)
+	filePath := path.Join(directory, path.Base(fileURL.Path))
 	// #nosec G304
 	file, err := os.Create(filePath)
 	if err != nil {

internal/chartverifier/checks/checks_test.go

@@ -643,11 +643,13 @@ func TestSignatureIsValid(t *testing.T) {
 		},
 	}
 
+	config := viper.New()
+	var base64Key string
+	var encodeErr error
+
 	for _, tc := range testCases {
 		t.Run(tc.description, func(t *testing.T) {
-			config := viper.New()
-			base64Key := ""
-			var encodeErr error
+			base64Key = ""
 			if len(tc.keyFile) > 0 {
 				base64Key, encodeErr = tool.GetEncodedKey(tc.keyFile)
 				require.NoError(t, encodeErr)