Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some SonarQube issues #319

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

Roming22
Copy link
Member

No description provided.

@Roming22 Roming22 requested a review from otaviof November 21, 2024 15:20
@openshift-ci openshift-ci bot requested review from flacatus and xinredhat November 21, 2024 15:21
Copy link
Collaborator

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 21, 2024
@openshift-ci openshift-ci bot removed the lgtm label Nov 29, 2024
@Roming22 Roming22 force-pushed the fix/sonarcloud branch 2 times, most recently from e3f4e0a to a85ad0e Compare December 11, 2024 10:16
@Roming22 Roming22 force-pushed the fix/sonarcloud branch 2 times, most recently from 76bd972 to f4de747 Compare December 17, 2024 11:42
Copy link
Collaborator

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 20, 2024
Copy link

openshift-ci bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: otaviof, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4360abc into redhat-appstudio:main Dec 20, 2024
11 checks passed
@Roming22 Roming22 deleted the fix/sonarcloud branch January 22, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants