Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gihub app and Smee for kflux-ocp-p01 #4988

Merged

Conversation

gbenhaim
Copy link
Member

  1. A new github app was created for kflux-ocp-p01 - https://github.com/apps/konflux-kflux-ocp-p01

  2. Configure the external secrets paths for pulling the secret of the new app.

  3. Configure a new channel for the smee client.

  4. Add the public IPs of the the NAT gateways of kflux-ocp-p01 to the allow list of the Smee server.

1. A new github app was created for kflux-ocp-p01 -
https://github.com/apps/konflux-kflux-ocp-p01

2. Configure the external secrets paths for pulling the secret of the
new app.

3. Configure a new channel for the smee client.

4. Add the public IPs of the the NAT gateways of kflux-ocp-p01 to the
allow list of the Smee server.

Signed-off-by: Gal Ben Haim <[email protected]>
Copy link
Contributor

@manish-jangra manish-jangra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gbenhaim, hugares, manish-jangra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 412ebdb into redhat-appstudio:main Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants