Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vector for forwarding Pipelines log #4952

Merged

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Nov 21, 2024

This is needed to enable a newer version of Results which is shipped to other customers.

For now, we are using play.min.io for dev environment.

Copy link

openshift-ci bot commented Nov 21, 2024

Hi @khrm. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @enarha

@divyansh42
Copy link
Member

/ok-to-test

@khrm khrm force-pushed the f/vector-tekton-log-collector branch 6 times, most recently from 63c3f3e to 8e257f8 Compare November 21, 2024 13:05
@khrm khrm force-pushed the f/vector-tekton-log-collector branch from 8e257f8 to 514a849 Compare November 21, 2024 13:46
@khrm
Copy link
Contributor Author

khrm commented Nov 21, 2024

/retest

@khrm khrm force-pushed the f/vector-tekton-log-collector branch from 514a849 to e9aae9e Compare November 21, 2024 14:47
@enarha
Copy link
Contributor

enarha commented Nov 21, 2024

/ok-to-test

@khrm khrm force-pushed the f/vector-tekton-log-collector branch 4 times, most recently from 2431931 to b7cc533 Compare November 22, 2024 07:08
This is needed for enabling newer version of Results which is shipped
to other customers.
@khrm khrm force-pushed the f/vector-tekton-log-collector branch from b7cc533 to 58b9be1 Compare November 22, 2024 08:34
@enarha
Copy link
Contributor

enarha commented Nov 25, 2024

/ok-to-test

@enarha
Copy link
Contributor

enarha commented Nov 26, 2024

/lgtm

@enarha
Copy link
Contributor

enarha commented Nov 26, 2024

/approve

Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: enarha, khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@enarha
Copy link
Contributor

enarha commented Nov 26, 2024

/ok-to-test

@enarha
Copy link
Contributor

enarha commented Nov 26, 2024

/test appstudio-e2e-tests

@manish-jangra manish-jangra merged commit 411e0a0 into redhat-appstudio:main Nov 26, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants