Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mintmaker: fix invalid k8s cronjob schedule #4948

Merged

Conversation

qixiang
Copy link
Collaborator

@qixiang qixiang commented Nov 20, 2024

The k8s CronJob schedule uses a syntax similar to Linux crontab, but it has a key difference: the day of the week field only accepts values from 0 to 6.

The k8s CronJob schedule uses a syntax similar to Linux crontab, but
it has a key difference: the day of the week field only accepts values
from 0 to 6.
Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hugares, qixiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hugares hugares merged commit 6fc052d into redhat-appstudio:main Nov 20, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants