Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: promote project-controller to production #4933

Conversation

yftacherzog
Copy link
Member

This introduces into production a change in which the controller watches also over the project and template resources.
konflux-ci/project-controller#124

This introduces into production a change in which the controller watches
also over the project and template resources.
konflux-ci/project-controller#124

Signed-off-by: Yftach Herzog <[email protected]>
@yftacherzog
Copy link
Member Author

@ifireball I confirmed in stage that template changes are reconciled and that creating the project after the dev stream and template results in owner ref being created on the dev stream.

Copy link
Contributor

@ifireball ifireball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ifireball, yftacherzog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ifireball
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4449700 into redhat-appstudio:main Nov 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants