Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kubearchvie to v0.4.0 #4929

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

mafh314
Copy link
Contributor

@mafh314 mafh314 commented Nov 18, 2024

Updating KubeArchive from 0.3.0 to 0.4.0. I deleted from the patch the resource quota for the sink and api component since that is part of the KubeArchive deployment yaml files (introduced by the OpenTelemetry instrumentation). The other changes are related to the yaml lint.

Copy link

openshift-ci bot commented Nov 18, 2024

Hi @mafh314. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hugares
Copy link
Contributor

hugares commented Nov 18, 2024

/ok-to-test

@rh-hemartin
Copy link
Contributor

/approve

@skoved
Copy link
Contributor

skoved commented Nov 19, 2024

/approve

@skoved
Copy link
Contributor

skoved commented Nov 19, 2024

/lgtm

@rh-hemartin
Copy link
Contributor

@hugares how can make this progress?

@rh-hemartin
Copy link
Contributor

/retest

Copy link

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mafh314, rh-hemartin, skoved

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hugares
Copy link
Contributor

hugares commented Nov 21, 2024

@hugares how can make this progress?

There is a bogus check (Red Hat Konflux) that I do not know how to get rid of when PR is opened by someone that is not a member of the org...

Merging this one

@hugares hugares merged commit 3586dfc into redhat-appstudio:main Nov 21, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants