patch to staging cluster-provisioner pod read #4903
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ascerra The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -0,0 +1,8 @@ | |||
| apiVersion: rbac.authorization.k8s.io/v1 | |||
| kind: ClusterRole | |||
There was a problem hiding this comment.
Patching the resource like this will replace it entirely. Use kustomize build components/cluster-as-a-service/staging to verify the resulting ClusterRole contains the rules from the base rbac plus your changes.
Take a look at this patch for an example of how to append to an array: https://github.com/redhat-appstudio/infra-deployments/blob/b22e629801630a927a1b0f5aed8d6dfea8319c9c/components/cluster-as-a-service/staging/add-hypershift-params.yaml
There was a problem hiding this comment.
Alright based on the newest changes I'm adding new resources instead of editing existing ones so I shouldn't be replacing anything.
ascerra
force-pushed
the
eaas-read-pod-logs
branch
2 times, most recently
from
4999c2a
to
f08bfed
Compare
| subjects: | ||
| - kind: ServiceAccount | ||
| name: namespace-manager | ||
| namespace: ${SPACE_NAME}-eaas |
There was a problem hiding this comment.
Variable substitution isn't going to work here. This is only applicable when dealing with the kubesaw tiers.
Signed-off-by: Adam Scerra <[email protected]>
ascerra
force-pushed
the
eaas-read-pod-logs
branch
from
f08bfed
to
66f1ce8
Compare
This PR should patch the clusterRole cluster-provisioner to also allow for getting pod logs.