Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO-NOT-MERGE] Install Tekton Results through operator #4600

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

enarha
Copy link
Member

@enarha enarha commented Sep 25, 2024

This only changes development overlay as a start.

@enarha enarha force-pushed the switch-results-operator branch 3 times, most recently from c9362ad to 40a19d3 Compare October 27, 2024 14:17
Copy link

openshift-ci bot commented Oct 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: enarha
Once this PR has been reviewed and has the lgtm label, please assign simonbaird for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@enarha enarha force-pushed the switch-results-operator branch 2 times, most recently from cbadd40 to 051849c Compare October 27, 2024 16:07
@enarha
Copy link
Member Author

enarha commented Oct 28, 2024

/test appstudio-e2e-tests

@enarha enarha force-pushed the switch-results-operator branch 3 times, most recently from 982ac02 to 5e0ef49 Compare October 29, 2024 12:31
@enarha
Copy link
Member Author

enarha commented Oct 29, 2024

/test appstudio-e2e-tests

@enarha
Copy link
Member Author

enarha commented Oct 30, 2024

/test appstudio-e2e-tests

3 similar comments
@enarha
Copy link
Member Author

enarha commented Oct 30, 2024

/test appstudio-e2e-tests

@enarha
Copy link
Member Author

enarha commented Nov 4, 2024

/test appstudio-e2e-tests

@enarha
Copy link
Member Author

enarha commented Nov 4, 2024

/test appstudio-e2e-tests

@enarha enarha force-pushed the switch-results-operator branch 5 times, most recently from e6669a7 to 4753aec Compare November 5, 2024 12:17
@enarha enarha force-pushed the switch-results-operator branch 2 times, most recently from 1377caa to 47c269e Compare November 10, 2024 09:40
This only changes development overlay as a start.
The option to provide path to cert is not available in the OSP oprrator.
Until it is added, test with no verification.
Still not supported by the OSP operator. Removing temporary to allow
testing.
Also remove S3_HOSTNAME_IMMUTABLE, set to default value (false) anyway.
The option has been depricated and should be completely removed.
The operator overrides this value, so it and argocd fight over it
blocking the deployment.
It is now deployed by the OSP operator as part of the Tekton Results
deployment.
The operator expects secret named `tekton-results-postgres` while orinal
secret name is `tekton-results-database`. The name of the fields in the
secret also changed.
With operator now supporting those configuration options, we add them
back to configuration.
With the DB installed through the operator, we can't provide TLS
certificate and key, thus we can't enabled TLS verification in the API.
@enarha
Copy link
Member Author

enarha commented Nov 13, 2024

/test appstudio-e2e-tests

@enarha
Copy link
Member Author

enarha commented Nov 18, 2024

/test appstudio-e2e-tests

Rerquired with the newest version which has it set to false by default.
@enarha
Copy link
Member Author

enarha commented Nov 19, 2024

/test appstudio-e2e-tests

Currently created "manually" by init container.
@enarha
Copy link
Member Author

enarha commented Nov 19, 2024

/test appstudio-e2e-tests

Copy link

openshift-ci bot commented Nov 19, 2024

@enarha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-e2e-tests aa61ba1 link true /test appstudio-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants