-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO-NOT-MERGE] Install Tekton Results through operator #4600
base: main
Are you sure you want to change the base?
Conversation
c9362ad
to
40a19d3
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: enarha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cbadd40
to
051849c
Compare
/test appstudio-e2e-tests |
982ac02
to
5e0ef49
Compare
/test appstudio-e2e-tests |
65a62f1
to
c71ce06
Compare
/test appstudio-e2e-tests |
3 similar comments
/test appstudio-e2e-tests |
/test appstudio-e2e-tests |
/test appstudio-e2e-tests |
e6669a7
to
4753aec
Compare
68ccf35
to
8f8dc9b
Compare
1377caa
to
47c269e
Compare
47c269e
to
51eb934
Compare
199c04f
to
4c9a967
Compare
2fd6169
to
1b967bb
Compare
This only changes development overlay as a start.
The option to provide path to cert is not available in the OSP oprrator. Until it is added, test with no verification.
Still not supported by the OSP operator. Removing temporary to allow testing. Also remove S3_HOSTNAME_IMMUTABLE, set to default value (false) anyway.
The option has been depricated and should be completely removed. The operator overrides this value, so it and argocd fight over it blocking the deployment.
It is now deployed by the OSP operator as part of the Tekton Results deployment.
The operator expects secret named `tekton-results-postgres` while orinal secret name is `tekton-results-database`. The name of the fields in the secret also changed.
With operator now supporting those configuration options, we add them back to configuration.
This reverts commit 47a55cf.
1b967bb
to
d0e2b7a
Compare
With the DB installed through the operator, we can't provide TLS certificate and key, thus we can't enabled TLS verification in the API.
d0e2b7a
to
07a4ea3
Compare
/test appstudio-e2e-tests |
tekton-results-retention-policy-agent is not used by Konflux.
/test appstudio-e2e-tests |
Rerquired with the newest version which has it set to false by default.
/test appstudio-e2e-tests |
Currently created "manually" by init container.
/test appstudio-e2e-tests |
@enarha: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This only changes development overlay as a start.