Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for Application deletion #383

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

johnmcollier
Copy link
Member

What does this PR do?:

Adds a metric for tracking successful and failed application deletions in HAS.

Which issue(s)/story(ies) does this PR fixes:

https://issues.redhat.com/browse/DEVHAS-452

PR acceptance criteria:

  • Unit/Functional tests

  • Documentation

  • Client Impact

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnmcollier,kim-tsao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: John Collier <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Aug 25, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2023

New changes are detected. LGTM label has been removed.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 82.88% and project coverage change: -0.64% ⚠️

Comparison is base (1afd7ae) 84.61% compared to head (3a8d5f1) 83.98%.
Report is 88 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
- Coverage   84.61%   83.98%   -0.64%     
==========================================
  Files          27       31       +4     
  Lines        3530     4259     +729     
==========================================
+ Hits         2987     3577     +590     
- Misses        402      514     +112     
- Partials      141      168      +27     
Files Changed Coverage Δ
pkg/devfile/errors.go 100.00% <ø> (ø)
controllers/component_controller_finalizer.go 63.46% <41.66%> (-11.54%) ⬇️
pkg/util/ioutils/ioutils.go 86.95% <50.00%> (-13.05%) ⬇️
controllers/component_controller.go 73.15% <60.56%> (-4.45%) ⬇️
cdq-analysis/pkg/devfile.go 68.30% <68.30%> (ø)
cdq-analysis/pkg/componentdetectionquery.go 69.28% <69.28%> (ø)
controllers/componentdetectionquery_controller.go 74.51% <71.42%> (+3.97%) ⬆️
pkg/github/token_mock.go 75.67% <75.67%> (-24.33%) ⬇️
controllers/application_controller.go 80.59% <77.33%> (-0.94%) ⬇️
cdq-analysis/pkg/detect.go 73.78% <83.92%> (ø)
... and 17 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnmcollier johnmcollier merged commit 1c302a6 into redhat-appstudio:main Aug 25, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants