-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metric for Application deletion #383
Add metric for Application deletion #383
Conversation
Signed-off-by: John Collier <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, kim-tsao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: John Collier <[email protected]>
New changes are detected. LGTM label has been removed. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
==========================================
- Coverage 84.61% 83.98% -0.64%
==========================================
Files 27 31 +4
Lines 3530 4259 +729
==========================================
+ Hits 2987 3577 +590
- Misses 402 514 +112
- Partials 141 168 +27
☔ View full report in Codecov by Sentry. |
What does this PR do?:
Adds a metric for tracking successful and failed application deletions in HAS.
Which issue(s)/story(ies) does this PR fixes:
https://issues.redhat.com/browse/DEVHAS-452
PR acceptance criteria:
Unit/Functional tests
Documentation
Client Impact
How to test changes / Special notes to the reviewer: