Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVHAS-453] Fix Kube-Linter errors #381

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

johnmcollier
Copy link
Member

What does this PR do?:

This PR addresses the errors found by kube-linter:

  • Adds CPU and Memory requests and limits to the rbac proxy container
  • Enables readOnlyRootFilesystem for both containers (HAS and rbac proxy)
  • Adds an empty dir volume for the /tmp directory for HAS to be able to write to

Which issue(s)/story(ies) does this PR fixes:

https://issues.redhat.com/browse/DEVHAS-453

PR acceptance criteria:

  • Unit/Functional tests

  • Documentation

  • Client Impact

How to test changes / Special notes to the reviewer:

  1. Download Kube-Linter from https://github.com/stackrox/kube-linter
  2. cd into config/default
  3. Run kustomize build . > mainfests.yaml
  4. Run kube-linter lint manifests.yaml. You should see:
KubeLinter development

No lint errors found!

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 82.55% and project coverage change: -0.75% ⚠️

Comparison is base (1afd7ae) 84.61% compared to head (bd612d6) 83.87%.
Report is 84 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
- Coverage   84.61%   83.87%   -0.75%     
==========================================
  Files          27       31       +4     
  Lines        3530     4230     +700     
==========================================
+ Hits         2987     3548     +561     
- Misses        402      515     +113     
- Partials      141      167      +26     
Files Changed Coverage Δ
pkg/devfile/errors.go 100.00% <ø> (ø)
controllers/component_controller_finalizer.go 63.46% <41.66%> (-11.54%) ⬇️
pkg/util/ioutils/ioutils.go 86.95% <50.00%> (-13.05%) ⬇️
controllers/component_controller.go 73.15% <60.56%> (-4.45%) ⬇️
cdq-analysis/pkg/devfile.go 68.30% <68.30%> (ø)
cdq-analysis/pkg/componentdetectionquery.go 69.28% <69.28%> (ø)
controllers/componentdetectionquery_controller.go 74.51% <71.42%> (+3.97%) ⬆️
pkg/github/token_mock.go 75.67% <75.67%> (-24.33%) ⬇️
controllers/application_controller.go 80.00% <76.81%> (-1.53%) ⬇️
cdq-analysis/pkg/detect.go 73.38% <80.85%> (ø)
... and 17 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-ci
Copy link

openshift-ci bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, maysunfaisal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnmcollier,maysunfaisal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnmcollier johnmcollier merged commit 8abc319 into redhat-appstudio:main Aug 22, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants