[RHTAPBUGS-595]add deletecollection permission to controllers #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephanie <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -64,7 +64,7 @@ type SnapshotEnvironmentBindingReconciler struct { | |||
|
|
|||
| const asebName = "SnapshotEnvironmentBinding" | |||
|
|
|||
| //+kubebuilder:rbac:groups=appstudio.redhat.com,resources=snapshotenvironmentbindings,verbs=get;list;watch;create;update;patch;delete | |||
| //+kubebuilder:rbac:groups=appstudio.redhat.com,resources=snapshotenvironmentbindings,verbs=get;list;watch;create;update;patch;delete;deletecollection | |||
There was a problem hiding this comment.
do we need to update config/rbac?
Signed-off-by: Stephanie <[email protected]>
johnmcollier
requested changes
Aug 15, 2023
| @@ -62,7 +62,7 @@ type ApplicationReconciler struct { | |||
|
|
|||
| const applicationName = "Application" | |||
|
|
|||
| //+kubebuilder:rbac:groups=appstudio.redhat.com,resources=applications,verbs=get;list;watch;create;update;patch;delete | |||
| //+kubebuilder:rbac:groups=appstudio.redhat.com,resources=applications,verbs=get;list;watch;create;update;patch;delete;deletecollection | |||
There was a problem hiding this comment.
HAS itself doesn’t need the deletecollection verb, just the RHTAP users, so we don’t need to add it to HAS here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR adds deletecollection verb to controllers
Which issue(s)/story(ies) does this PR fixes:
https://issues.redhat.com/browse/RHTAPBUGS-595
PR acceptance criteria:
Unit/Functional tests
Documentation
Client Impact
How to test changes / Special notes to the reviewer: