[DEVHAS-434] Move GitOps operations to Go module #377

johnmcollier · 2023-08-04T21:24:38Z

What does this PR do?:

Originally based on changes in #256

This PR updates HAS to separate out the GitOps resource generation into separate Go module, gitops-generator, which is local to this repository
The gitops/ folder, which contained only unused functions has been removed
Support for two environment variables added to HAS:
- DO_GITOPS_JOB: when true/false toggles between gitops generation in a Kubernetes job, or within HAS. Currently inactive when set to true.
- ALLOW_LOCAL_GITOPS_GEN: when set to true when DO_GITOPS_JOB is true, it will allow resources which have the allowLocalGitopsGen: true annotation to use local GitOps generation instead.

Which issue(s)/story(ies) does this PR fixes:

https://issues.redhat.com/browse/DEVHAS-434

PR acceptance criteria:

Unit/Functional tests
Documentation
Client Impact

How to test changes / Special notes to the reviewer:

Signed-off-by: John Collier <[email protected]>

openshift-ci · 2023-08-04T21:24:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [johnmcollier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: John Collier <[email protected]>

openshift-ci · 2023-08-10T16:25:12Z

@johnmcollier: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/application-service-e2e	`45f2e6c`	link	true	`/test application-service-e2e`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.