Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVHAS-380] Have the Application controller add/remove components from its model #363

Merged
merged 10 commits into from
Aug 1, 2023

Merge branch 'appmanagecomp' of github.com:johnmcollier/application-s…

1fca333
Select commit
Loading
Failed to load commit list.
Merged

[DEVHAS-380] Have the Application controller add/remove components from its model #363

Merge branch 'appmanagecomp' of github.com:johnmcollier/application-s…
1fca333
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 1, 2023 in 1s

84.09% (-0.52%) compared to 1afd7ae

View this Pull Request on Codecov

84.09% (-0.52%) compared to 1afd7ae

Details

Codecov Report

Patch coverage: 83.23% and project coverage change: -0.52% ⚠️

Comparison is base (1afd7ae) 84.61% compared to head (1fca333) 84.09%.
Report is 77 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   84.61%   84.09%   -0.52%     
==========================================
  Files          27       31       +4     
  Lines        3530     4226     +696     
==========================================
+ Hits         2987     3554     +567     
- Misses        402      507     +105     
- Partials      141      165      +24     
Files Changed Coverage Δ
pkg/devfile/errors.go 100.00% <ø> (ø)
controllers/component_controller.go 73.87% <62.31%> (-3.72%) ⬇️
cdq-analysis/pkg/devfile.go 68.30% <68.30%> (ø)
cdq-analysis/pkg/componentdetectionquery.go 69.28% <69.28%> (ø)
controllers/componentdetectionquery_controller.go 74.51% <71.42%> (+3.97%) ⬆️
controllers/component_controller_finalizer.go 67.34% <75.00%> (-7.66%) ⬇️
pkg/github/token_mock.go 75.67% <75.67%> (-24.33%) ⬇️
controllers/application_controller.go 80.00% <76.81%> (-1.53%) ⬇️
cdq-analysis/pkg/detect.go 73.38% <79.54%> (ø)
pkg/github/token.go 87.74% <84.95%> (-7.65%) ⬇️
... and 17 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.