[RHTAPBUGS-322] Properly update SEB status #362
Conversation
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
==========================================
- Coverage 84.61% 84.09% -0.53%
==========================================
Files 27 27
Lines 3530 4149 +619
==========================================
+ Hits 2987 3489 +502
- Misses 402 494 +92
- Partials 141 166 +25
☔ View full report in Codecov by Sentry. |
| @@ -385,7 +385,17 @@ func (r *SnapshotEnvironmentBindingReconciler) Reconcile(ctx context.Context, re | |||
| componentStatus.GitOpsRepository.GeneratedResources = componentGeneratedResources[componentName] | |||
| } | |||
|
|
|||
| appSnapshotEnvBinding.Status.Components = append(appSnapshotEnvBinding.Status.Components, componentStatus) | |||
| componentUpdated := false | |||
There was a problem hiding this comment.
are we putting this back in? I thought we always updated status on reconcile with your prev PR 🤔
There was a problem hiding this comment.
There was a problem hiding this comment.
Different variable. We're using this to determine if a new component was added to the status or one was updated. I'll rename it to avoid confusion
| @@ -158,7 +158,7 @@ func (r *SnapshotEnvironmentBindingReconciler) Reconcile(ctx context.Context, re | |||
| var tempDir string | |||
| clone := true | |||
|
|
|||
| appSnapshotEnvBinding.Status.Components = []appstudiov1alpha1.BindingComponentStatus{} | |||
| //appSnapshotEnvBinding.Status.Components = []appstudiov1alpha1.BindingComponentStatus{} | |||
Signed-off-by: John Collier <[email protected]>
|
@maysunfaisal Review comments addressed |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flacatus, johnmcollier, maysunfaisal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
Changes how we update the SEB status during reconciles to ensure the route name is always persisted. If we can do so without breaking other components, it would be best to change the
BindingComponentarray in the status to a map later on.Which issue(s)/story(ies) does this PR fixes:
https://issues.redhat.com/browse/RHTAPBUGS-322
PR acceptance criteria:
Unit/Functional tests
Documentation
Client Impact
How to test changes / Special notes to the reviewer: