[RHTAPBUGS-442 Redux] Ensure gitops repository is cleaned up in error states

[johnmcollier]

What does this PR do?:

This PR fixes some leftover git clones that were not being cleaned up when an error occurred, in the Component finalizer and SEB controller.

Which issue(s)/story(ies) does this PR fixes:

https://issues.redhat.com/browse/RHTAPBUGS-442

PR acceptance criteria:

• Unit/Functional tests

• Documentation

• Client Impact

How to test changes / Special notes to the reviewer:

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, maysunfaisal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [johnmcollier,maysunfaisal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[johnmcollier]

/retest

[openshift-ci]

New changes are detected. LGTM label has been removed.

[johnmcollier]

/retest

[johnmcollier]

/retest

[johnmcollier]

/retest

[codecov]

Codecov Report

Patch coverage: 84.06% and project coverage change: -0.82 ⚠️

Comparison is base (1afd7ae) 84.61% compared to head (5540ac3) 83.80%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
- Coverage   84.61%   83.80%   -0.82%     
==========================================
  Files          27       27              
  Lines        3530     4156     +626     
==========================================
+ Hits         2987     3483     +496     
- Misses        402      505     +103     
- Partials      141      168      +27     

Impacted Files	Coverage Δ
controllers/component_controller_finalizer.go	73.46% <50.00%> (-1.54%)	⬇️
controllers/component_controller.go	71.72% <57.36%> (-5.88%)	⬇️
controllers/componentdetectionquery_controller.go	69.85% <73.13%> (-0.69%)	⬇️
pkg/devfile/detect.go	72.97% <73.52%> (+0.32%)	⬆️
pkg/github/token_mock.go	75.67% <75.67%> (-24.33%)	⬇️
...pplicationsnapshotenvironmentbinding_controller.go	82.12% <81.02%> (-2.80%)	⬇️
pkg/github/token.go	87.74% <84.95%> (-7.65%)	⬇️
pkg/util/util.go	95.63% <89.36%> (-0.78%)	⬇️
pkg/github/mock.go	94.25% <90.99%> (-5.75%)	⬇️
pkg/devfile/devfile.go	84.35% <93.39%> (+1.14%)	⬆️
... and 12 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.