Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
This PR should fix some issues for test T1613-1 and T1613-2:
name=value
format.--rm
option in thedocker run
command to make sure its resources are deleted and that running this test multiple times does not fail because of "container name already in use" error. The other viable option is to add thedocker rm command
in the cleanup phase right after the container is stopped. Let me know if you have a strong opinion on this.docker rmi
command failed because the docker image ist1613
and nott1613_container
, which is instead the container name.Testing:
Tested on Ubuntu 20.04