Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SVG files self-contained by converting text to paths and updating licensing #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

koraytaylan
Copy link

Overview

I am planning to use the SVG files from this repository in an app I'm developing. I encountered a few issues related to font usage and licensing, which I've addressed in this pull request.

Changes Made

  1. Converted Text Elements to Paths

    • Reason: To make the SVG files self-sufficient and independent of external font files, I converted the text elements to vector paths. This ensures that the SVGs render consistently without requiring the "Roboto Slab" font to be installed or loaded.
    • License Compliance: The "Roboto Slab" font is licensed under the Apache License 2.0, which permits this type of use.
    • Tools Used:
      • svg-text-to-path: Converted text elements to paths.
      • SVGO: Optimized the SVG files for better performance.
  2. Updated Licensing Section and Added Apache License 2.0

    • Reason: While the attribution for "Roboto Slab" was already present in the README.md, I added a separate Licensing section to include both the existing license and the attribution required by the Apache License 2.0.
    • Actions:
      • Added a LICENSE-APACHE file containing the Apache License 2.0 text.
      • Created a Licensing section in the README.md to consolidate licensing information, including both the existing license and the Apache License attribution.
  3. Replaced Non-Free Font Reference

    • Issue: One of the SVG files referenced a non-free font that requires a paid license.
    • Solution: Replaced the non-free font with "Roboto Slab" to maintain consistency and ensure licensing compliance.
    • Recommendation: It might be prudent to review other files to ensure they do not reference any non-free fonts.

Motivation

  • Self-Sufficiency: By converting text to paths, the SVG files become self-contained and do not depend on external font files, ensuring consistent rendering.
  • Licensing Compliance: Ensured that all fonts used are properly licensed and that the repository complies with all licensing requirements.
  • Optimization: Improved the SVG files' performance through optimization, which benefits the app's loading times and efficiency.

same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing copyright owner info.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clue whether it is intentional or not but the original repository for this font also has that part empty inside the licence 😅
https://github.com/googlefonts/robotoslab/blob/main/LICENSE.txt

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that's the downside of injecting any license this easily. No one reads the fine print anymore. Most of the apache projects also have lack of copyright information. Even though it's explicitly and very very clearly stated in their own license. lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants