Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default, use net_http_persistent adapter #25

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

bpedro
Copy link
Contributor

@bpedro bpedro commented Mar 24, 2015

giphy-2

What?

Start using the net_http_persistent Faraday adapter by default.

Why?

To improve HTTPS loading times, taking advantage of persistence features such as keep-alive.

@franciscoj
Copy link
Contributor

👍

@jrom
Copy link
Contributor

jrom commented Mar 24, 2015

It would be good to add in the PR description some sort of benchmark with this change to approve that it actually improves something. 💬 ➕ 👍

@andresgutgon
Copy link

🍏 👍

@sauloperez
Copy link

agree with @jrom 🍏 👍

@alexandrebini
Copy link
Contributor

🍏 👍

@jrom
Copy link
Contributor

jrom commented Mar 25, 2015

Copying from the task:

Here's a preliminary performance analysis for backing up an organization with the following items:
2 projects
71 users
7 task lists
40 tasks
330 files
(ZIP file size is 716MB)
Here are the performance results using different strategies:
SimpleTree: 13m42.250s
SimpleTree + API calls keep-alive: 9m21.703s
FastTree with 8 threads + API calls keep-alive: 5m32.223s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants