Skip to content

Conversation

@smaeul
Copy link
Contributor

@smaeul smaeul commented Nov 18, 2025

Previously, it would always remove the topic name when adding the alias, even the first time, so the mapping would not be set on the server, and the server would reject the packet.

@redboltz
Copy link
Owner

I think your fix is correct. In the LRU case, the behavior should be “register the topic alias,” not “use the topic alias.”
However, it looks like the CI is reporting failures (I’ve re-run it several times).

I suspect that the expected value in the test might be wrong. Could you take a look?

Previously, it would always remove the topic name when adding the alias,
even the first time, so the mapping would not be set on the server, and
the server would reject the packet.
@smaeul smaeul force-pushed the up/fix-topic-alias branch from f7f8fad to 2328d15 Compare November 20, 2025 00:04
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.91%. Comparing base (fe389da) to head (2328d15).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   90.89%   90.91%   +0.01%     
==========================================
  Files          55       55              
  Lines        7460     7470      +10     
==========================================
+ Hits         6781     6791      +10     
  Misses        679      679              
Files with missing lines Coverage Δ
src/mqtt/connection/core.rs 86.36% <100.00%> (ø)
src/mqtt/packet/v5_0/publish.rs 94.52% <100.00%> (+0.03%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@redboltz
Copy link
Owner

Thank you for updating.

@redboltz redboltz merged commit 199dca1 into redboltz:main Nov 20, 2025
10 checks passed
@smaeul smaeul deleted the up/fix-topic-alias branch November 26, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants