Disconnect when receiving an unsuccessful CONNACK #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MQTT v3.1.1 requires: "If a server sends a CONNACK packet containing a non-zero return code it MUST then close the Network Connection [MQTT-3.2.2-5]."
MQTT v5.0 requires: "If a Server sends a CONNACK packet containing a Reason code of 128 or greater it MUST then close the Network Connection [MQTT-3.2.2-7]."
Since the network connection is guaranteed to be closed from the server side, the library can detect this and request to close the socket on the client side.
The user could handle this by separately parsing the
NotifyPacketReceived(Connack)event, but this seems like a reasonable convenience to provide for clients that don't care about the reason code, if you agree. This ordering was simplest to implement, but may be theRequestCloseevent should come after theNotifyPacketReceived?