Avoid duplicate libraries when building with -Zbuild-std
#47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These hashbrown features are intended to be used only when building that library as part of `std` from inside the rustc workspace. Normally, if these features are enabled outside of a compiler build, the crates.io versions of `rustc-std-workspace-core` and `rustc-std-workspace-alloc` harmlessly wrap the `core` and `alloc` crates from the compiler's sysroot. But when using `-Zbuild-std`, they create a second conflicting copy of `core` and `alloc` inside the local workspace: ``` $ cargo build --no-default-features -Z build-std=core,alloc Compiling hashbrown v0.15.5 error[E0464]: multiple candidates for `rmeta` dependency `core` found | = note: candidate redboltz#1: mqtt-protocol-core/target/debug/deps/libcore-63212f86292bc9b2.rmeta = note: candidate redboltz#2: mqtt-protocol-core/target/debug/deps/librustc_std_workspace_core-87d6eaf43c4c124e.rmeta error[E0464]: multiple candidates for `rmeta` dependency `alloc` found --> hashbrown-0.15.5/src/lib.rs:64:1 | 64 | extern crate alloc; | ^^^^^^^^^^^^^^^^^^^ | = note: candidate redboltz#1: mqtt-protocol-core/target/debug/deps/liballoc-72d6465b9ee82117.rmeta = note: candidate redboltz#2: mqtt-protocol-core/target/debug/deps/librustc_std_workspace_alloc-a3fbb36e3ffcf55c.rmeta ```
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 90.91% 90.90% -0.01%
==========================================
Files 55 55
Lines 7459 7456 -3
==========================================
- Hits 6781 6778 -3
Misses 678 678 🚀 New features to boost your workflow:
|
Owner
|
@smaeul , thank you for sending the PR. It looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These hashbrown features are intended to be used only when building that library as part of
stdfrom inside the rustc workspace. Normally, if these features are enabled outside of a compiler build, the crates.io versions ofrustc-std-workspace-coreandrustc-std-workspace-allocharmlessly wrap thecoreandalloccrates from the compiler's sysroot. But when using-Zbuild-std, they create a second conflicting copy ofcoreandallocinside the local workspace: